Default to dark theme for EC#7162
Conversation
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7162 +/- ##
===========================================
- Coverage 80.53% 80.52% -0.02%
===========================================
Files 2705 2705
Lines 78030 78033 +3
Branches 10532 10532
===========================================
- Hits 62843 62837 -6
- Misses 11128 11137 +9
Partials 4059 4059 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I think a better way to do this is to force the Dark theme at the Activity level:
Add the lines:
ForcedDarkElementTheme(
colors = colors,
) {at the beginning of the block ElementThemeApp in the class ElementCallActivity.
That should do it and also take care of the status bar and other side effects of forcing the theme to dark.
Here is a patch:
elementCallDarkTheme.patch
This indeed sounds like a smarter way. I like it |
d7c2283 to
f4741c2
Compare
(this is the intended design on light and dark system configuration)
f4741c2 to
ed48c03
Compare
(this is the intended design on light and dark system configuration)
Content
This change is related (and required) for: element-hq/element-call#4067
Motivation and context
element-hq/element-call#4067
Tested devices
Checklist